#438 ✓resolved
Xavier Noria

render :js should be render :json in section 12.4

Reported by Xavier Noria | September 11th, 2010 @ 06:10 PM | in The Rails 3 Way

As the title says, render :js should be render :json in section 12.4.

Otherwise Rack::JSONP does not wrap the response because it checks whether

is_json?(headers) && has_callback?(request)

and is_json? is defined to be

def is_json?(headers)
  headers.key?('Content-Type') && headers['Content-Type'].include?('application/json')
end

A bare render :js sets a content type of "application/javascript" and Rack::JSONP does nothing.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Shared Ticket Bins

People watching this ticket

Tags

Referenced by

Pages